Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translations for New Job screen #5334

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

takashiharano
Copy link
Contributor

No JIRA

Added Japanese translations for New Job screen.

The comparison between English and Japanese is as follows:
diff

Proposed changelog entries

  • Entry 1: Add Japanese translations for New Job screen

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@res0nance res0nance added localization rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Mar 4, 2021
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution!

I don't know whether we have active contributors who speak Japanese, so I wouldn't know who to ask for a review. I put this submission through Google Translate, looks reasonably close 😄

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 6, 2021
@timja
Copy link
Member

timja commented Mar 6, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit e3d5073 into jenkinsci:master Mar 8, 2021
@takashiharano takashiharano deleted the newjob-ja branch March 8, 2021 09:17
@takashiharano takashiharano restored the newjob-ja branch March 8, 2021 09:18
@takashiharano takashiharano deleted the newjob-ja branch March 8, 2021 09:20
@MarkEWaite MarkEWaite mentioned this pull request Mar 23, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants