Remove JTidy from core #5521
Merged
Remove JTidy from core #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added
dependencies
|
I have the same results with usage-in-plugins, only the two plugins use it and only the single class. The PR build doesn't have the dependency bundled anymore, otherwise no differences. usage-in-plugins classes file I used(Including both variants of class name is easier than remembering which one is used) |
daniel-beck
approved these changes
May 24, 2021
oleg-nenashev
approved these changes
May 24, 2021
There was a problem hiding this comment.
No objections. This dependency is too old to keep maintaining it in the core. JDepends plugin was updated for JEP-200 and Co, and other plugins can be trivially updated as well
timja
approved these changes
May 24, 2021
jglick
approved these changes
May 24, 2021
|
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process |
oleg-nenashev
added
the
ready-for-merge
res0nance
approved these changes
May 24, 2021
basil
added a commit
to basil/update-center2
that referenced
this pull request
May 25, 2021
daniel-beck
pushed a commit
to jenkins-infra/update-center2
that referenced
this pull request
Jun 21, 2021
Formally deprecating plugins left behind in jenkinsci/jenkins#5320, jenkinsci/jenkins#5338, jenkinsci/jenkins#5521, and jenkinsci/jenkins#5526.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins core ships JTidy 4aug2000r7-dev-hudson-1, a fork of JTidy 04aug2000r7-dev. The original 04aug2000r7-dev release was published on August 1, 2001; the fork was published on July 14, 2008. JTidy was forked by Kohsuke in commit 2fcca36 as part of the fix for JENKINS-1680 to resolve an incompatibility with IBM WebSphere 6.1, which itself reached end-of-life on September 30, 2013.
Carrying this ancient fork of an even more ancient dependency does not seem desirable for the Jenkins project. In recent years there have been efforts to revive the JTidy project on GitHub, but rather than migrating to this revival project I think it makes more sense to remove the JTidy dependency from core. The dependency is effectively unused throughout the entire Jenkins ecosystem, so there is no strong reason to keep bundling it.
Nothing in Jenkins core itself uses JTidy. Running the classes from the JTidy JAR through
usage-in-pluginsand searching for usages in sources, I found only two references in plugins:Proposed changelog entries
Developer: Remove JTidy dependency from Jenkins core. Plugins that use JTidy functionality, including NIS notification lamp, must be updated to explicitly declare a dependency on JTidy rather than relying on Jenkins core to provide this library.
Proposed upgrade guidelines
The JTidy dependency has been removed from Jenkins core. Users of JDepend must upgrade JDepend to the latest version. Other plugins that use JTidy functionality, including NIS notification lamp, must be updated to explicitly declare a dependency on JTidy rather than relying on Jenkins core to provide this library.
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).