Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include symbol-annotation in core BOM #5940

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Conversation

basil
Copy link
Member

@basil basil commented Nov 20, 2021

See jenkinsci/jenkins#5293 (comment). Now that symbol-annotation has been split into its own repository, encourage plugins to use the dependency from Jenkins core rather than the structs plugin by adding symbol-annotation to the core (not plugin!) BOM. The corresponding change to stop bundling this with structs is jenkinsci/structs-plugin#112. Note that I am not upgrading the version of this library yet. I want to wait until jenkinsci/structs-plugin#112 is released and more plugins adopt the new release of structs before I do that in order to avoid unnecessary migration pain.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the skip-changelog Should not be shown in the changelog label Nov 20, 2021
test/pom.xml Outdated Show resolved Hide resolved
@basil basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Nov 22, 2021
test/pom.xml Outdated Show resolved Hide resolved
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 23, 2021
@timja
Copy link
Member

timja commented Nov 23, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit ab64e65 into jenkinsci:master Nov 23, 2021
@basil basil deleted the symbol-annotation branch November 23, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants