Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list indentation #6874

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Fix list indentation #6874

merged 2 commits into from
Jul 18, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 18, 2022

#6863 only makes it more obvious that the formatting here was wrong, without actually fixing it.

Proposed changelog entries

  • N/A

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@jglick jglick requested a review from timja July 18, 2022 13:09
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Jul 18, 2022
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see what was meant by the comment now, thanks 😄

only makes it more obvious that the formatting here was wrong, without actually fixing it.

No plans to do changes in that PR other than the specifics and the auto formatting, improvements should be extracted out like this 😄

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 18, 2022
@timja
Copy link
Member

timja commented Jul 18, 2022

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@jglick
Copy link
Member Author

jglick commented Jul 18, 2022

I should have mentioned that you need to look at the rich diff here to see the mistake in the existing formatting.

@timja timja merged commit 7509a69 into master Jul 18, 2022
@timja timja deleted the CONTRIBUTING.md branch July 18, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants