Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69240] Version select input is out of style with other drop down select input #6963

Merged
merged 5 commits into from
Aug 8, 2022
Merged

[JENKINS-69240] Version select input is out of style with other drop down select input #6963

merged 5 commits into from
Aug 8, 2022

Conversation

ridemountainpig
Copy link
Contributor

@ridemountainpig ridemountainpig commented Aug 4, 2022

See JENKINS-69240.

Before

截圖 2022-08-04 下午8 48 49

After

截圖 2022-08-04 下午8 47 53

Proposed changelog entries

  • Version select input is out of style with other drop down select input

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault changed the title JENKINS-69240 Version select input is out of style with other drop down select input [JENKINS-69240] Version select input is out of style with other drop down select input Aug 4, 2022
@NotMyFault NotMyFault added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features needs-security-review Awaiting review by a security team member labels Aug 4, 2022
@NotMyFault NotMyFault requested review from a team August 4, 2022 21:29
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine UI wise, but introduces

TypeError: Cannot read properties of undefined (reading 'tagName')
    at findInFollowingTR (hudson-behavior.js:389:14)
    at hudson-behavior.js:1384:21
    at Array.forEach (<anonymous>)
    at behavior.js:116:30
    at Array.forEach (<anonymous>)
    at behavior.js:111:27
    at Array.forEach (<anonymous>)
    at Object.applySubtree (behavior.js:93:17)
    at F.expand (repeatable.js:66:19)
    at Object.onAdd (repeatable.js:141:15)

@ridemountainpig
Copy link
Contributor Author

Looks fine UI wise, but introduces

I have fix it.

Thanks~

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 6, 2022
@basil
Copy link
Member

basil commented Aug 6, 2022

Sorry, I didn't notice the needs-security-review label. I guess this needs to wait for that...

@basil basil removed the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 6, 2022
@yaroslavafenkin yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Aug 8, 2022
@NotMyFault NotMyFault added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 8, 2022
@timja timja merged commit 2072281 into jenkinsci:master Aug 8, 2022
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Aug 14, 2022
…down select input (jenkinsci#6963)

Co-authored-by: Alexander Brandes <mc.cache@web.de>
(cherry picked from commit 2072281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants