-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide native Java 11 HTTP client versions of FormValidation#URLCheck
methods
#7508
Conversation
@@ -367,7 +367,7 @@ public static InputStream getInputStream(URL url) throws IOException { | |||
* @since TODO | |||
*/ | |||
public static HttpClient newHttpClient() { | |||
return newHttpClientBuilder().build(); | |||
return newHttpClientBuilder().followRedirects(HttpClient.Redirect.NORMAL).build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change while I was here: while testing with URLs like https://app.assembla.com/login that have a redirect, I noticed that the old HttpURLConnection
API automatically followed redirects but the new Java 11 HTTP client API was not. To ease migration I figured it would be best to follow redirects by default. I could not think of a case where you would not want to follow them, and it matches the behavior of the old API. Of course anyone who wants to opt out can always do so by creating a custom builder without this option (something that was not possible with the old API).
@@ -499,9 +552,9 @@ protected FormValidation handleIOException(String url, IOException e) throws IOE | |||
// any invalid URL comes here | |||
if (e.getMessage().equals(url)) | |||
// Sun JRE (and probably others too) often return just the URL in the error. | |||
return error("Unable to connect " + url); | |||
return error("Unable to connect " + url, e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor unrelated change while I was here: append the stack trace for debuggability. We love stack traces.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks! |
Building on #7398, provide native Java 11 HTTP client versions of
FormValidation#URLCheck
methods, deprecating the oldHttpURLConnection
methods in favor of these and adding test coverage for the new functionality (the old functionality had no test coverage).Testing done
Ran
mvn clean verify -Dtest=hudson.util.FormValidationTest
locally. As a bonus, I convertedhudson.plugins.git.browser.AssemblaWebDoCheckURLTest#testInitialChecksOnRepoUrl
to this new API and verified that doing so chased away the weird Java 19 problem I was seeing in jenkinsci/bom#1637 (comment).Proposed changelog entries
Provide native Java 11 HTTP client versions of
FormValidation#URLCheck
methodsProposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).