Backporting for 2.375.3 #7590
Merged
Backporting for 2.375.3 #7590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NotMyFault
commented
Jan 17, 2023
•
NotMyFault
commented
30 tasks
jglick
reviewed
Jan 17, 2023
…ents plugin (jenkinsci#7568) * Hide split of windows-slaves from other plugins https://issues.jenkins.io/browse/JENKINS-70301 notes that the WMI Windows Agents plugin (id:windows-slaves) was split from core in 1.547 and is now deprecated. Because it is deprecated, users want to remove it. They cannot remove it if they have plugins installed that depend on a Jenkins version prior to 1.547. Only two plugins actually depend of any classes from the WMI Windows Agent plugin. * cli-extras-plugin - never released, no tags, no install history * multi-slave-config - already requires windows-slaves plugin explicitly and already requires a Jenkins core version newer than 1.547. 1340 installations, last released 8 years ago Rather than require updates of all the plugins that require a Jenkins version less than 1.547, this removes the windows-slaves plugin from the split plugins list. Users will not be warned that their plugin might have a dependency on windows-slaves because the analysis has confirmed that there is only 1 delivered plugin with that dependency, and it is an explicitly declared dependency with a newer Jenkins minimum version than the version from which the WMI Windows Agents plugion was split. Testing done * Installed suggested plugins from wizard and confirmed WMI Windows Agents plugin is not installed * Installed slave-setup plugin (has implied WMI Windows Agents plugin dependency) and confirmed that WMI Windows Agents plugin is not installed * Installed multi-slave-setup plugin (has explicit WMI Windows Agents plugin dependency) and confirmed that WMI Windows Agents plugin was installed as a dependency * Remove multi-slave-setup plugin and WMI Windows Agents plugin and confirmed that Jenkins reported no errors or issues * Installed five plugins with old base versions and confirmed that WMI Windows Agents plugin was not installed. The five plugins included backup-plugin, cloudbees-credentials-plugin, unity3d-plugin, groovy-label-assignment-plugin, and maven-deployment-linker plugin. * Performed a backup with the backup plugin and confirmed that it was well behaved https://docs.google.com/spreadsheets/d/1KDIJIu41rIRlj6PjzyhAY9vazKmd3PVwqM3_-32Lt-o/edit?usp=sharing lists the plugins that have an implied dependency on the WMI Windows Agents plugin. * Remove windows-slaves from war file No need to bundle a detached plugin that has no consumers of its API that are based on a Jenkins version before the plugin was split from core. jenkinsci#7568 (review) detected that the bundling was left in by the original commit. (cherry picked from commit f0cbe38)
NotMyFault
force-pushed
the
backporting-for-2.375.3
branch
from
51c89ea to
47a2f3c
Compare
MarkEWaite
approved these changes
Jan 17, 2023
basil
reviewed
Jan 17, 2023
There was a problem hiding this comment.
At the time of this writing JENKINS-70240 remains rejected, for a reason I believe is invalid as explained in JENKINS-70240 (comment).
basil
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Between this PR and #7597, the content of 2.375.3 looks good to me (though I see no reason to retain the 2.375.3-rejected label on JENKINS-70240).
MarkEWaite
pushed a commit
to jenkins-infra/jenkins.io
that referenced
this pull request
Feb 2, 2023
This is to add the changelog & upgrade guide for LTS 2.375.3, this includes the backports from the [backporting ticket](jenkinsci/jenkins#7590).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.