[JENKINS-71200] Fix elements property overload in ListView #7942

Dohbedoh · 2023-05-05T04:28:44Z

ListView produces <input ..> elements for each items within the ItemGroup that are named directly after the item name itself. If an item name is elements, this kind of overloads the form.elements attribute which causes a bad form submission.

The propose fix is to prefix the input names with item_ to avoid the overload.

Testing done

Started Jenkins
create an freestyle job named elements
create a view and Save

Proposed changelog entries

Prefix the name of input elements of ListView to prevent form submission issues when an Item (job) is named elements.

Proposed upgrade guidelines

N/A

Submitter checklist

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
- Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

Maintainer checklist

Before the changes are marked as ready-for-merge:

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Dohbedoh · 2023-05-05T04:51:45Z

First commit is a test that reproduces the problem and show the failure.
Second commit is the fix.

timja · 2023-05-07T19:05:43Z

@NotMyFault / @Dohbedoh was this introduced in 2.403?

Dohbedoh · 2023-05-07T22:30:49Z

@timja I don't think so. I find this out on an instance running 2.361.3. And I could reproduce this although in the latest weekly 2.403. This has probably been around for a while.

NotMyFault · 2023-05-08T00:03:42Z

@NotMyFault / Dohbedoh was this introduced in 2.403?

Unlikely, I just labeled it as regression because I recall it working at some point.

timja · 2023-05-08T07:23:40Z

I doubt this ever worked

timja

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

daniel-beck · 2023-07-07T16:41:03Z

I doubt this ever worked

FTR this hasn't worked in many years, if ever (at least for some attribute names), see #6959 / JENKINS-10693.

basil · 2023-07-14T18:53:05Z

core/src/main/java/hudson/model/ListView.java

@@ -452,7 +452,7 @@ protected void submit(StaplerRequest req) throws ServletException, FormException
            }
            for (TopLevelItem item : items) {
                String relativeNameFrom = item.getRelativeNameFrom(getOwner().getItemGroup());
-                if (req.getParameter(relativeNameFrom) != null) {
+                if (req.getParameter("item_" + relativeNameFrom) != null) {


jenkinsci/categorized-view-plugin#38

basil · 2023-07-14T22:51:17Z

Caused JENKINS-71403.

basil · 2023-07-14T22:54:35Z

https://github.com/jenkinsci/calendar-view-plugin/blob/7cdb173e5890913c9297d6f9e0bc59cc7ec817bf/src/main/resources/io/jenkins/plugins/view/calendar/CalendarView/configure-entries.jelly#L292 needs to be adapted as well.

basil · 2023-07-17T14:19:25Z

https://github.com/jenkinsci/calendar-view-plugin/blob/7cdb173e5890913c9297d6f9e0bc59cc7ec817bf/src/main/resources/io/jenkins/plugins/view/calendar/CalendarView/configure-entries.jelly#L292 needs to be adapted as well.

Filed JENKINS-71663 to track this regression.

basil · 2023-07-17T15:24:12Z

Added upgrade-guide-needed to cover the fact that the following plugins must be upgraded in lockstep with this change:

https://plugins.jenkins.io/radiatorviewplugin/ is also impacted, but likely too old to be relevant. Should likely be deprecated.

Dohbedoh added 2 commits May 5, 2023 14:20

[JENKINS-71200] Add test for ListView attributes overloads

a4b3e5a

[JENKINS-71200] Fix elements property overload in ListView

1f7e8cb

Dohbedoh changed the title ~~[JENKINS-71200] Add test for ListView attributes overloads~~ [JENKINS-71200] Fix elements property overload in ListView May 5, 2023

NotMyFault added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label May 5, 2023

NotMyFault requested a review from a team May 5, 2023 07:49

timja added bug For changelog: Minor bug. Will be listed after features and removed regression-fix Pull request that fixes a regression in one of the previous Jenkins releases labels May 8, 2023

NotMyFault approved these changes May 10, 2023

View reviewed changes

NotMyFault requested review from a team May 10, 2023 17:16

timja approved these changes May 21, 2023

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 21, 2023

NotMyFault merged commit a45f060 into jenkinsci:master May 22, 2023

basil added a commit to basil/categorized-view-plugin that referenced this pull request Jul 14, 2023

Adapt to jenkinsci/jenkins#7942

cd8a067

basil mentioned this pull request Jul 14, 2023

Adapt to jenkinsci/jenkins#7942 jenkinsci/categorized-view-plugin#38

Merged

basil reviewed Jul 14, 2023

View reviewed changes

basil added a commit to jenkinsci/categorized-view-plugin that referenced this pull request Jul 14, 2023

Adapt to jenkinsci/jenkins#7942 (#38)

d8a5721

basil added a commit to basil/jenkins-build-monitor-plugin that referenced this pull request Jul 14, 2023

Adapt to jenkinsci/jenkins#7927 and jenkinsci/jenkins#7942

7fc1653

basil added a commit to jenkinsci/build-monitor-plugin that referenced this pull request Jul 14, 2023

Adapt to jenkinsci/jenkins#7927 and jenkinsci/jenkins#7942 (#794)

e2023a3

basil added the upgrade-guide-needed This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed label Jul 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-71200] Fix elements property overload in ListView #7942

[JENKINS-71200] Fix elements property overload in ListView #7942

Dohbedoh commented May 5, 2023 •

edited by timja

Loading

Dohbedoh commented May 5, 2023

timja commented May 7, 2023

Dohbedoh commented May 7, 2023

NotMyFault commented May 8, 2023

timja commented May 8, 2023

timja left a comment

daniel-beck commented Jul 7, 2023

basil Jul 14, 2023

basil commented Jul 14, 2023

basil commented Jul 14, 2023

basil commented Jul 17, 2023

basil commented Jul 17, 2023

[JENKINS-71200] Fix elements property overload in ListView #7942

[JENKINS-71200] Fix elements property overload in ListView #7942

Conversation

Dohbedoh commented May 5, 2023 • edited by timja Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

Dohbedoh commented May 5, 2023

timja commented May 7, 2023

Dohbedoh commented May 7, 2023

NotMyFault commented May 8, 2023

timja commented May 8, 2023

timja left a comment

Choose a reason for hiding this comment

daniel-beck commented Jul 7, 2023

basil Jul 14, 2023

Choose a reason for hiding this comment

basil commented Jul 14, 2023

basil commented Jul 14, 2023

basil commented Jul 17, 2023

basil commented Jul 17, 2023

Dohbedoh commented May 5, 2023 •

edited by timja

Loading