Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71394] Fedora 38 should not show EOL warning until 2024 #8082

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Jun 2, 2023

jenkins-infra/jenkins.io#6431 and JENKINS-71394

Testing done

Confirmed that the message is incorrectly reported with Jenkins 2.407 installed in a Fedora 38 container image. Confirmed that the message is not reported when a 2.408-SNAPSHOT build is included in a Fedora 38 container image with this change.

Proposed changelog entries

  • Do not show Fedora 38 as an end of life operating system before actual end of life in 2024.

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@MarkEWaite, the one who created the bug

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for detecting that mistake. Approved!

@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Jun 2, 2023
@MarkEWaite MarkEWaite self-assigned this Jun 2, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault changed the title Fedora 38 should not show EOL warning until 2024 [JENKINS-71394] Fedora 38 should not show EOL warning until 2024 Jun 2, 2023
@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

@MarkEWaite MarkEWaite merged commit 8b81750 into jenkinsci:master Jun 3, 2023
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Jun 10, 2023
…kinsci#8082)

Fedora 38 should not show EOL warning until 2024

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
(cherry picked from commit 8b81750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants