Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nested list from GitHub tasklist #8119

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jun 10, 2023

Remove indented entry from tasklist

When I submitted #8118 , the task list failed to render until I removed the indented list item

Testing done

Confirmed with #8118 that the new markup is accepted by the tasklist

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@timja @NotMyFault

Before the changes are marked as ready-for-merge:

Maintainer checklist

When I submitted jenkinsci#8118 , the
task list failed to render until I removed the indented list item
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Jun 10, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that one was missing, thanks for spotting quickly!

@NotMyFault NotMyFault requested review from timja-bot and timja and removed request for timja-bot June 10, 2023 13:41
@NotMyFault NotMyFault merged commit c470f19 into jenkinsci:master Jun 10, 2023
@MarkEWaite MarkEWaite deleted the adjust-task-list branch June 12, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants