Make toggleLogKeep button primary

[lucaswerkmeister]

This matches the appearance in earlier Jenkins versions, and makes the button more visible. The button doesn’t have any associated more primary button, nor much else to draw attention to it (it’s just kind of floating on the page).

No associated Jira issue.

Testing done

I added the jenkins-button--primary class in dev tools, on a random build in Wikimedia’s CI infrastructure.
Before:

After:

(I’m just assuming that primary="true" will result in that class being added, I haven’t set up a local test environment.)

Proposed changelog entries

• Style the "Keep this build forever" and "Don't keep this build forever" buttons as primary.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described. – There is no Jira issue.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests. – I don’t expect there are any tests covering this markup. (If there are, I guess CI will point them out?)
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate. – N/A
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable. – N/A
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials. – N/A
8. For new APIs and extension points, there is a link to at least one consumer. – N/A

Desired reviewers

CC @janfaracik, who had added the primary="false" in b7b37d5 (part of #7203) – I’m not sure if it was intentional or just part of a large-scale update of all sorts of buttons. Also CC @hashar who helped digging up the relevant code :)

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[welcome]

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

[hashar]

The keep this build forever button becoming light gray was definitely surprising. For additional context we have upgraded our instance from 2.375.4 to 2.401.1 last week hence why we haven't noticed earlier.

As mentioned in the PR, I believe the change made by b7b37d5 is a mistake, given #7203 has 14 commits and probably involves a lot of search and replaces, I guess it was easy to miss.

[timja]

It was intentionally changed here:
#7203 (comment)

I think there's a lack of contrast on the default theme for non primary buttons that is making it more of an issue.

It's not really a primary action as-in that's what people go to the page to do, so we don't really want the users eye drawn to it when they load the page. Looking at the page the primary button really pulls you to look at it.

[janfaracik]

It was intentionally changed here:

#7203 (comment)

I think there's a lack of contrast on the default theme for non primary buttons that is making it more of an issue.

It's not really a primary action as-in that's what people go to the page to do, so we don't really want the users eye drawn to it when they load the page. Looking at the page the primary button really pulls you to look at it.

+1 to this really. I’d avoid using the primary class for this button as it’s a rarely used action. The secondary buttons do need some contrast work.

[NotMyFault]

Thanks for the PR @lucaswerkmeister, but I'm with Jan and Tim, the change proposed wouldn't make a good addition.

[lucaswerkmeister]

I think there's a lack of contrast on the default theme for non primary buttons that is making it more of an issue.

Then I look forward to that getting fixed more generally.