Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-71715] Allow plugins with alternate build log visualizations to handle console links from core and other plugins #8321
[JENKINS-71715] Allow plugins with alternate build log visualizations to handle console links from core and other plugins #8321
Changes from 3 commits
4862fa0
ecc7e50
d1f3aa2
4316970
519adfd
618f538
f8fa8fe
a976eb6
d853004
2dd4e97
018789a
3d9b41c
7305016
6491cbb
5f051c9
e1b938b
ae52b83
46b9cda
4f12b2b
2ab2ea9
c34df9d
2f669da
a7ac1fd
f650e1f
f8c0aac
598ca1c
848b20c
48dcff8
b5420ad
bcf46b6
a4d5a21
64c3faa
7e51da5
88ea796
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
jenkins.…
packages for new types.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to create a
jenkins.console
package and put it there or put it in the already-existinghudson.console
package?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a legitimate use case for when this code would be reached?
Display URL API has this because the URLs are used outside Jenkins and computed in a non-request context. It seems these URLs are always used in a request context, as they're used to render parts of the UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, it would probably be better to design the new API to work with URLs relative to the context root, and then use something like
'/' + Stapler.getCurrentRequest().getContextPath() + getConsoleURL(run)
to build the console URLs.The implementation of the extension that should go into jenkinsci/display-url-api-plugin#194 would need to convert the absolute URLs into context path-relative URLs though, and I guess what I was thinking here would no longer apply, since we would want to use
ConsoleURLProvider
for all links in the Jenkins UI andDisplayUrlProvider.getConsoleUrl
only when producing external links.EDIT: Although now I wonder if there is a use case where people want to redirect to a completely separate external logging system, e.g. maybe you use
opentelemetry
as described here and want to direct users to some Elasticsearch frontend instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems like something that could be interesting. Summoning @cyrille-leclerc WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it some more -- just after the ping comment, sorry Cyrille -- this could also easily be implemented by having a Jenkins-internal URL that redirects to the outside system, instead of linking there directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniel-beck. Regarding the OpenTelemetry integrations where Jenkins pipeline logs are persisted in an external logs management system rather than in the Jenkins home, all integrations I am aware of want to
I don't see any OTel integration scenario wanting to create an alternative pipeline logs visualization GUI in Jenkins.
Does it make sense?