Add Appearance system configuration page

[timja]

This adds a new system configuration page 'Appearance' for configuring the look and feel of Jenkins.
It moves a bit of config out of the main System page into a more appropriate place.

Screenshots

It implements the design from https://jenkins-redesign.vercel.app/settings/appearance

It complements #8379 but doesn't require it

I've gone through a number of plugins that contribute UI and have sent pull requests for:

TODO

Preview Give feedback

1. Move configuration to appearance page simple-theme-plugin#156
   6 of 6
   enhancement +1
   
2. Move configuration to appearance page theme-manager-plugin#210
   6 of 6
   enhancement +1
3. Move configuration to appearance page customizable-header-plugin#15
   6 of 6
   breaking enhancement +2
4. Move configuration to appearance page prism-api-plugin#109
   6 of 6
   enhancement +1
   

I have gone for ones that directly affect the look and feel of Jenkins rather than ones that affect builds like ansicolor.
Any other suggestions?

After #7268 is in the user profile page can be updated to match.

Could possibly move the Display notification URL provider to appearance too? (the thing that selects Classic, Blue Ocean or Pipeline Graph View)

Testing done

Started Jenkins with no plugins contributing to the appearance category, the page doesn't show.

Installed jenkinsci/theme-manager-plugin#210, the page shows up and theme manager is on the appearance page and not on the system configuration page.

Unit test wise I don't think there's much value for it will something in core uses it, although happy to add something if its thought to be needed

Proposed changelog entries

• Add appearance system configuration page

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[TobiX]

Nice. https://plugins.jenkins.io/test-results-analyzer/ looks like an additional candidate, but mixes appearance settings with other settings...

[Kevin-CB]

From a security perspective, I see no blockers!

[timja]

Nice. plugins.jenkins.io/test-results-analyzer looks like an additional candidate, but mixes appearance settings with other settings...

I've had a look but I don't think it fits with the page that well.
I'm trying to have it be more for things that affect look and feel as a whole rather than some niche plugin config

[janfaracik]

I think this is great! LGTM.

Would be good to see something similar in #7268 if it's going forward.

[NotMyFault]

That's awesome!

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

It moves a bit of config out of the main System page into a more appropriate place.

Previously, creation of new config categories were motivated by overcrowding on the global configuration (Tools, Clouds, possibly Security as well – matrix-auth gets huge quickly). This doesn't seem to be the case here. What motivates this change, what's special about this config page that does not apply to tons of other potential categories?

Also, we should better define what goes here so plugin maintainers know what's appropriate to put there. The discussion about some plugins above indicates this isn't the case.

[timja]

Previously, creation of new config categories were motivated by overcrowding on the global configuration (Tools, Clouds, possibly Security as well – matrix-auth gets huge quickly). This doesn't seem to be the case here. What motivates this change, what's special about this config page that does not apply to tons of other potential categories?

This groups related elements together, originally I had started jenkinsci/theme-manager-plugin#105 but that would've been a breaking change at configuration level. This pull request #8379 then reminded of the design https://jenkins-redesign.vercel.app/settings/appearance. Which seemed like a much cleaner approach to solve the problem.

It means that you can configure the look and feel of Jenkins from one place without having to scroll all over the place to find it.

what's special about this config page that does not apply to tons of other potential categories

Other sensible categories could likely be added if there are enough sensible elements that would go there? e.g. possibly notifications?

Also, we should better define what goes here so plugin maintainers know what's appropriate to put there. The discussion about some plugins above indicates this isn't the case.

22b858b (#8403)

[daniel-beck]

Other sensible categories could likely be added if there are enough sensible elements that would go there? e.g. possibly notifications?

That makes sense if we move from "this is unwieldy, split it up" to "categories are based on loosely coupled semantic relationships between elements". That seems like a JEP-level change though given the downstream impact.

[timja]

Other sensible categories could likely be added if there are enough sensible elements that would go there? e.g. possibly notifications?

That makes sense if we move from "this is unwieldy, split it up" to "categories are based on loosely coupled semantic relationships between elements". That seems like a JEP-level change though given the downstream impact.

The javadoc already says that as far as I can tell

jenkins/core/src/main/java/jenkins/model/GlobalConfigurationCategory.java

Line 11 in 8ff1445

* Grouping of related {@link GlobalConfiguration}s.

[jonesbusy]

Looks login-theme-plugin was forgotten.

I've open a PR here : jenkinsci/login-theme-plugin#37

Regards,

[KalleOlaviNiemitalo]

On the System configuration page, I see a few settings that could perhaps be moved to Appearance:

• "System Message" (Jenkins.systemMessage). Especially because the Customizable Header plugin has its own "System Message" setting on the Appearance page.
• "ANSI Color": was already rejected above.
• "Additional Sidebar Links" (Sidebar Link plugin): Didn't find an existing issue for this.
• "Prism Syntax Highlighting Configuration" (Prism API plugin): Didn't find an existing issue for this.

If there's no objection, I think I'll file issues for the last two in a few days.

[uhafner]

• "Prism Syntax Highlighting Configuration" (Prism API plugin): Didn't find an existing issue for this.

https://github.com/jenkinsci/prism-api-plugin/releases/tag/v1.29.0-9

[jonesbusy]

"Additional Sidebar Links" (Sidebar Link plugin): Didn't find an existing issue for this.

As a user of sidebar-link I think it should be moved to appearance as well. But you should check with maintainer. Not sure if there is "guidelines" of what is appearance and what is not

[timja]

"Additional Sidebar Links" (Sidebar Link plugin): Didn't find an existing issue for this.

As a user of sidebar-link I think it should be moved to appearance as well. But you should check with maintainer. Not sure if there is "guidelines" of what is appearance and what is not

Yeah it makes sense for that to go there, https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/jenkins/appearance/AppearanceCategory.java#L30-L41