-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry for Jenkins uptime #8596
Conversation
a572d9c
to
431d245
Compare
</ul> | ||
|
||
Additionally this trial collects the list of installed plugins, their version, and the version of Jenkins. | ||
This data will help understand unexpected submission frequency of other trials' data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly different wording than in the screenshot.
@@ -0,0 +1,11 @@ | |||
<?jelly escape-by-default='true'?> | |||
<j:jelly xmlns:j="jelly:core"> | |||
This trial collects two timestamps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why collect both endpoints instead of just the difference? I guess this makes it easier to tell when a single correlator is somehow being used by multiple instances because of overlapping but non-equal endpoints. Are there any other reasons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this makes it easier to tell when a single correlator is somehow being used by multiple instances because of overlapping but non-equal endpoints.
That's the idea. Multiple submissions will have the same start time if and only if Jenkins wasn't restarted in between.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!
@daniel-beck this seems to me like it might be a good candidate for backporting to the 2.426.1 LTS. Should it be an LTS candidate for 2.426.1 or would you prefer to wait for a later LTS release? |
@MarkEWaite Thanks for the reminder! I filed JENKINS-72248. I'm happy to wait if it's already late for 2.426.1. |
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> (cherry picked from commit 3218599)
@dwnusbaum and I noticed unexpected distribution of
correlator
s (see JEP-214) in the submissions to our telemetry trials (my #8440 and #7470 and and Devin's #7342).While most correlation IDs are submitted multiple times, up to once per day, there are outliers:
In both cases (mostly the second though), collecting Jenkins uptime should be able to help understand what's going on.
This does not use
jenkins.model.Uptime
as data source, as that's not stable given system time changes (I filed JENKINS-72157).Testing done
Changed system time by 5 minutes, re-ran this, no significant jump.
Also locally changed the start date to Oct 10 and manually triggered submission (
ExtensionList.lookupSingleton(jenkins.telemetry.Telemetry.TelemetryReporter.class).run()
), then checked it in Uplink.Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist