Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test timeout of MavenTest#sensitiveParameters() #8837

Merged

Conversation

NotMyFault
Copy link
Member

The change proposed updates the test timeout of MavenTest#sensitiveParameters(). For some yet unknown reason, the test takes ~220 (!!) seconds to complete on ci.jenkins.io.

Locally, the entire MavenTest takes less than 30s to complete, and used to take ~60s on ci.jenkins.io, as seen in a recent build a couple of days ago.

Out of an abundance of caution, looking towards the next weekly release, I'd propose to raise the test timeout temporarily, to restore a functional build on ci.jenkins.io and give us some time to look into it .

Testing done

mvn clean verify -Dtest=hudson.tasks.MavenTest is successful.

Proposed changelog entries

  • JENKINS-XXXXX, human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Jan 6, 2024
@NotMyFault NotMyFault requested a review from a team January 6, 2024 13:35
@MarkEWaite
Copy link
Contributor

We had a problem with the artifact caching proxy on at least one of the cloud providers. That problem inserted a 30 second timeout into certain maven operations. The test may be affected by that problem. Refer to the help desk ticket for more info

Currently being discussed and explored in the Jenkins infra gitter channel

@MarkEWaite
Copy link
Contributor

Merging to fix tests on the master branch

@MarkEWaite MarkEWaite merged commit 040cb89 into jenkinsci:master Jan 6, 2024
16 checks passed
@NotMyFault NotMyFault deleted the increase-test-timout-maventest branch January 6, 2024 17:05
@NotMyFault
Copy link
Member Author

Despite replaying the job, https://ci.jenkins.io/job/Core/job/jenkins/view/change-requests/job/PR-8835/ failed for the same reason. I'll file an independent helpdesk issue, thanks nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants