Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Swedish translation #9069

Merged
merged 34 commits into from
Apr 8, 2024
Merged

Updated Swedish translation #9069

merged 34 commits into from
Apr 8, 2024

Conversation

Regnander
Copy link
Contributor

@Regnander Regnander commented Mar 24, 2024

In this PR, I added new and updated existing properties/HTML files. There are some more HTML files to be translated, which I will take care of in a future PR.

No JIRA ticket. Since the majority of the most recent translation PRs lacked one, I figured this wasn't needed.

Testing done

Testing was done by browsing the various menus and settings to get proper context.


Proposed changelog entries

  • Major overhaul of the entire Swedish translation.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented Mar 24, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 24, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 24, 2024
@Regnander
Copy link
Contributor Author

I have no idea on how to solve the build errors, so any help would be appreciated.

@StefanSpieker
Copy link
Contributor

StefanSpieker commented Mar 24, 2024

I think it is complaining about the HTML files.

Code style issues found in 84 files. Run Prettier to fix.

You can build it on your machine and check that you are seeing the same error. You can fix it with prettier. In the ci process you can change the Line 799 in war/pom.xml to lint:fix, which should fix all problems, remember to revert the changes in the pom.xml before committing the changes.

@Regnander
Copy link
Contributor Author

My local repo is currently broken, so I manually formatted the affected HTML files. However, I still get the same lint error.

@NotMyFault
Copy link
Member

My local repo is currently broken, so I manually formatted the affected HTML files. However, I still get the same lint error.

The correct way to fix prettier issues is by running yarn run lint:fix followed by lint:ci to ensure locally, that your PR passes CI checks.

@Regnander
Copy link
Contributor Author

Regnander commented Mar 24, 2024

The correct way to fix prettier issues is by running yarn run lint:fix followed by lint:ci to ensure locally, that your PR passes CI checks.

That fixed the lint errors. Thanks!

However, this time the logs say "hudson.PluginManagerTest.updateSiteURLCheckValidation failed". Is there something I can do about this?

Edit: It seems like it was an external issue,

@NotMyFault NotMyFault added localization major-rfe For changelog: Major enhancement. Will be highlighted on the top labels Mar 27, 2024
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 28, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 30, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the pull request.

I resolved the conflict and merged the latest changes from the master branch so that a new CI build would evaluate the pull request again.

I've run the Jenkins controller with locale set to "sv_SE" using the Jenkins locale plugin and was able to see the Swedish translations from my Google Chrome browser. I checked a few of the translations with Google translate and confirmed that Google translate agrees with the translated strings.

I don't speak Swedish, but I believe that @rsandell does. I've approved this pull request based on my testing and my use of google translate to confirm the few strings I checked agreed with Google translate.

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 3, 2024
@MarkEWaite MarkEWaite self-assigned this Apr 3, 2024
@Regnander
Copy link
Contributor Author

@MarkEWaite Thanks for merging again. Is there anything I should do once the build is finished?

@MarkEWaite
Copy link
Contributor

@MarkEWaite Thanks for merging again. Is there anything I should do once the build is finished?

No, I think that the preferred next step is a review by another Swedish speaker. If that doesn't happen within a week, I will ask for a review by someone who is not a Swedish speaker so that it can be merged.

@NotMyFault
Copy link
Member

Thanks!


/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 7, 2024
@NotMyFault NotMyFault merged commit b0baeba into jenkinsci:master Apr 8, 2024
17 checks passed
Copy link

welcome bot commented Apr 8, 2024

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization major-rfe For changelog: Major enhancement. Will be highlighted on the top ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants