Remove 'Disable project' button from project view

[janfaracik]

Discussed briefly in the last UX Sig, the 'Disable project' (and 'Add/edit description') button take up a lot of vertical space (roughly 100px) and this forces useful information, such as stage view plugin etc down.

My proposal would be just to remove the 'Disable project' button altogether and instead have users rely on the configure screen to disable projects.

Before

After

Testing done

• Disable button has been removed, still possible to reenable a project from that view however

Proposed changelog entries

• Remove 'Disable project' button from project view.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[uhafner]

I never used that button on my own, but wouldn't it make sense to remove it when we move all those actions to the action bar?

[timja]

I never used that button on my own, but wouldn't it make sense to remove it when we move all those actions to the action bar?

This button is also on the configure page so its just duplicated so I think its a special case.

[daniel-beck]

Isn't this a good use case for app-bar buttons?

[janfaracik]

I never used that button on my own, but wouldn't it make sense to remove it when we move all those actions to the action bar?

Isn't this a good use case for app-bar buttons?

I agree with Tim here, this is a duplicated button that isn't very often used for how prominent it is. Demoed an app bar rework for the project page in the latest UX meeting in which it could live, but not sure how useful it would be to have there.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[basil]

This change breaks org.jenkinsci.plugins.workflow.job.WorkflowJobTest#disabled. Since I have detected the breakage before this change has shipped in a weekly release, and since I do not yet see a PR to adapt workflow-job to this breaking change, I am planning to revert this change before tomorrow's weekly ships to avoid breaking BOM/PCT. We can reintegrate this change in a future weekly once workflow-job has been adequately prepared for this breaking change. If a PR to adapt workflow-job to this breaking change appears before tomorrow's weekly release, then I won't revert this change.