[JENKINS-73586] Fix New Item page layout if no icon is defined for an item type

[scherler]

#9111

introduced a new styling however it broke the styling of the default icon generation in case there is no icon defined. as shown in 1aff74c

After fix

Testing done

Interactive checks

Proposed changelog entries

• Fix "New Item" page layout if no icon is defined for an item (regression in 2.453).

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[janfaracik]

Thanks!

Out of curiosity, is there a situation where an item type wouldn't provide an icon?

[mawinter69]

e.g. the Coordinator plugin implements a new project type but is not providing an icon or image. So it displays wrong:

[janfaracik]

e.g. the Coordinator plugin implements a new project type but is not providing an icon or image. So it displays wrong:

Thanks!

Any thoughts on this - Depending on how many plugins there are that don't provide an icon, could we instead update the plugins to include an icon rather than maintaining this logic in core?

[scherler]

There are some situations in which you cannot provide an icon without a bigger rewrite, IMHO it is there, and removing such functionality is problematic since we have no way of knowing how many plugins depend on this.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

This should have a Jira issue for backporting into LTS.

[scherler]

@daniel-beck I created JENKINS-73586