Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Root URL test for permissions assigned to groups #9906

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

daniel-beck
Copy link
Member

Vaguely motivated by JENKINS-73720: Confirm Resource Root URL works in principle when permissions are assigned to groups.

Testing done

n/a

Proposed changelog entries

n/a

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@daniel-beck daniel-beck added the skip-changelog Should not be shown in the changelog label Oct 23, 2024
@Test
public void groupPermissionsWork() throws Exception {
final JenkinsRule.DummySecurityRealm securityRealm = j.createDummySecurityRealm();
securityRealm.addGroups("alice", "admins");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out this line makes the test fail.

@MarkEWaite MarkEWaite merged commit 23bcc39 into jenkinsci:master Oct 25, 2024
15 checks passed
@daniel-beck daniel-beck deleted the test-group-impersonation branch October 28, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants