Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JEP-210 #166

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Updated JEP-210 #166

merged 2 commits into from
Aug 7, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 6, 2018

Moved a “reasoning” block from jenkinsci/workflow-job-plugin#27. Also adjusting wording to reflect the fact that jenkinsci/jenkins#3563 was merged.

@jglick jglick requested a review from oleg-nenashev August 6, 2018 21:31
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to read it when there is no design decision outlined in reasoning

@jglick
Copy link
Member Author

jglick commented Aug 7, 2018

It is hard to read it when there is no design decision outlined in reasoning

Sorry, could you clarify? Something wrong with this PR, or with what was there before or in the other PR?

@oleg-nenashev
Copy link
Member

For me it looks like that "Reasoning" section has no explicit design decision

@oleg-nenashev oleg-nenashev merged commit 3261649 into master Aug 7, 2018
@jglick jglick deleted the jglick-patch-1 branch August 8, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants