Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require workflow-aggregator #1145

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 9, 2018

Nothing should be referring to workflow-aggregator, which was just a do-nothing plugin created to make it easier for Jenkins 1.x users to install a bunch of Pipeline plugins. Be more specific about the plugins actually required for certain elements.

@jglick
Copy link
Member Author

jglick commented Nov 6, 2018

ping @daspilker I suppose

@daspilker daspilker merged commit fbd6ab2 into jenkinsci:master Jan 4, 2019
@jglick jglick deleted the workflow-aggregator branch January 7, 2019 15:27
@xbmono
Copy link

xbmono commented Feb 18, 2019

Sorry what does this change mean? Because I had this job dsl and it was working until we upgraded to this version:

pipelineJob("folder-management/tag-repositories") {
    description("To tag multiple repositories with a single tag")
    keepDependencies(false)
    displayName("Tag Repositories")
    logRotator(14)
    definition {
        cpsScm {
            """
//some code here
}"""		}
    }
}

with new version, I get error saying cps is required

@jglick
Copy link
Member Author

jglick commented Feb 18, 2019

I get error saying cps is required

You mean this? But it is required and always was.

@xbmono
Copy link

xbmono commented Feb 18, 2019

well, I don't know but my job dsl (the code above) was working without cps and you can see it in my code after we upgraded to this version (that contains this commit), I had to change my job to something like this:

pipelineJob("folder-management/tag-repositories") {
    description("To tag multiple repositories with a single tag")
    keepDependencies(false)
    displayName("Tag Repositories")
    logRotator(14)
    definition {
        cps {
            def myscript = """
//some code here
}"""		
         script(myScript)
          sandbox() 
}
    }
}

anyway it works now but was just wondering why

@jglick
Copy link
Member Author

jglick commented Feb 19, 2019

cps and cpsScm are both defined in the same plugin (workflow-cps) which is listed as @RequiresPlugin by both of those DSL methods, so I cannot imagine what difference there would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants