Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for sunset icon removal from core #1245

Conversation

NotMyFault
Copy link
Member

This is a preparation for https://github.com/jenkinsci/jenkins/pull/5778/ which removes sunset PNG and GIF icons.

@jamietanna Would be nice if you can also trigger a release after merging this PR. The core PR is blocked until then.
Thanks in advance!

To note, the required change is the warning icon in job-dsl-plugin/src/main/resources/javaposse/jobdsl/plugin/actions/SeedJobAction/jobMain.jelly, moving from a PNG to SVG icon is in my opinion nice to have, considering it aligns well with the modern Jenkins UI.
The SVG shares the same source like the PNG, therefore the license has not been modified.

The change proposed works well the newest weekly release:

as on the plugin baseline:

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@jamietanna jamietanna self-requested a review December 26, 2021 14:54
Copy link
Contributor

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'll get this merged + released next week, likely before New Year 🙌

@jamietanna jamietanna merged commit 34e5070 into jenkinsci:master Jan 1, 2022
@NotMyFault NotMyFault deleted the chore/master/prep-for-icon-removal-from-core branch January 1, 2022 18:22
@jamietanna
Copy link
Contributor

As you've noticed, this is now released 🙌

@NotMyFault
Copy link
Member Author

Yup, thanks for the quick merge and release 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants