Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing options for Parameterized Remote Trigger Plugin #1250

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Add missing options for Parameterized Remote Trigger Plugin #1250

merged 1 commit into from
Jul 18, 2022

Conversation

jsmrcka
Copy link
Contributor

@jsmrcka jsmrcka commented Jun 17, 2022

@rsvoboda
Copy link

@jsmrcka, is @jamietanna the one we want feedback from?

@jamietanna
Copy link
Contributor

jamietanna commented Jun 20, 2022 •
edited
Loading

Yes it is, I'll get round to it when I get a chance. Thanks for your patience!

@jamietanna jamietanna self-requested a review June 20, 2022 07:55
@rsvoboda
Copy link

ok, thank you

@jamietanna
Copy link
Contributor

Just to confirm, these aren't picked up by the Dynamic DSL?

@jsmrcka
Copy link
Contributor Author

jsmrcka commented Jul 12, 2022 •
edited
Loading

Just to confirm, these aren't picked up by the Dynamic DSL?

Good point: disabled is picked up, the others are not. I'll update (and rebase) the PR.

Edit: Sorry, my mistake. disabled is not picked up, just like the others.

@jsmrcka
Copy link
Contributor Author

jsmrcka commented Jul 18, 2022

@jamietanna Could we have the final review, please? See my previous comment.

Also, how soon can this be released?

@jamietanna jamietanna enabled auto-merge July 18, 2022 16:08
@jamietanna jamietanna merged commit 2fb0050 into jenkinsci:master Jul 18, 2022
@jamietanna
Copy link
Contributor

Tagged, released and should be live shortly 👍

@jsmrcka jsmrcka deleted the JENKINS-68781 branch July 19, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamietanna jamietanna jamietanna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsmrcka @rsvoboda @jamietanna