Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on Java 17 and 21 #1382

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Aug 17, 2023

Without dropping support for Java 11, add support for running mvn clean verify on Java 17 and 21.

@basil basil requested a review from a team as a code owner August 17, 2023 23:21
@basil
Copy link
Member Author

basil commented Aug 24, 2023

@jamietanna Thanks for the review. Could this PR please be merged and released to unblock plugin compatibility testing (PCT) on Java 17/21?

@jamietanna
Copy link
Contributor

Sure, I should have some time in the next couple of days to push a release!

@jamietanna jamietanna merged commit fb51265 into jenkinsci:master Sep 2, 2023
15 checks passed
@jamietanna
Copy link
Contributor

@basil I've just given the release steps a go and hit:

$ mvn release:prepare release:perform
...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Unknown packaging: hpi @ org.jenkins-ci.plugins:job-dsl:${revision}${changelist}, /home/jamie/workspaces/job-dsl-plugin/job-dsl-plugin/pom.xml, line 10, column 14
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.jenkins-ci.plugins:job-dsl:1.85-SNAPSHOT (/home/jamie/workspaces/job-dsl-plugin/job-dsl-plugin/pom.xml) has 1 error
[ERROR]     Unknown packaging: hpi @ org.jenkins-ci.plugins:job-dsl:${revision}${changelist}, /home/jamie/workspaces/job-dsl-plugin/job-dsl-plugin/pom.xml, line 10, column 14
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
mvn release:prepare release:perform  23.38s user 1.51s system 52% cpu 47.453 total

Is this one you've seen before?

@basil
Copy link
Member Author

basil commented Sep 2, 2023

Have you tried building in the parent directory?

@jamietanna
Copy link
Contributor

jamietanna commented Sep 2, 2023

This was from the root module - it appears to have been me running JDK8, JDK11 is now working.👏🏼

@basil basil deleted the refresh branch October 7, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants