Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make permissions matrix-auth-3.0+ compatible #1415

Conversation

eva-mueller-coremedia
Copy link
Contributor

@eva-mueller-coremedia eva-mueller-coremedia commented May 9, 2024

Make permissions matrix-auth-3.0+ compatible by adding support to explicitly assign permissions to groups or users.

With https://github.com/jenkinsci/matrix-auth-plugin/releases/tag/matrix-auth-3.0 ambiguous permissions will show a warning. With this change, matrix-auth-3.0+ users can resolve the warning by using the appropriate methods.

Closes #1249

See also https://issues.jenkins.io/browse/JENKINS-67411

Testing done

Added test cases and manually deployed and tested the hpi on a Jenkins 2.440.3 instance.

Job DLS

config-job-dsl

UI

config-ui

XML

config-xml

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@eva-mueller-coremedia eva-mueller-coremedia requested a review from a team as a code owner May 9, 2024 13:45
@eva-mueller-coremedia
Copy link
Contributor Author

@basil @jamietanna - are you still the main maintainers? It would be great if you could have a look at this PR.

@jamietanna
Copy link
Contributor

As per https://github.com/jenkinsci/job-dsl-plugin?tab=readme-ov-file#jenkins-job-dsl-plugin I'm looking for support with maintainence.

I appreciate that this is fixing a warning, but I think my priority - if I were to be able to have time to support the plugin - would be to triaging the other outstanding issues and work out priority from there

@eva-mueller-coremedia
Copy link
Contributor Author

eva-mueller-coremedia commented May 10, 2024

As per jenkinsci/job-dsl-plugin#jenkins-job-dsl-plugin I'm looking for support with maintainence.

I appreciate that this is fixing a warning, but I think my priority - if I were to be able to have time to support the plugin - would be to triaging the other outstanding issues and work out priority from there

Sure, prioritize as best for you. Glad to see that there is a maintainer left.

I would like to emphasize that this also addresses https://issues.jenkins.io/browse/JENKINS-67411 - maybe a coin to raise this issue in its priotity.

by adding support to explicitly assign permissions to groups or users.

With https://github.com/jenkinsci/matrix-auth-plugin/releases/tag/matrix-auth-3.0 ambiguous permissions will show a warning.
@eva-mueller-coremedia eva-mueller-coremedia force-pushed the feature/make-matrix-auth-3.0-compatible branch from ceb8bde to 280e1f2 Compare August 25, 2024 09:08
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit dfe148f into jenkinsci:master Aug 27, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants