Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73759] Remove deprecated usage of Spring Framework class #1460

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

alecharp
Copy link
Member

@alecharp alecharp commented Sep 11, 2024

See JENKINS-73759.

LocalVariableTableParameterNameDiscoverer was marked as deprecated in favour of StandardReflectionParameterNameDiscoverer. Since Spring Framework 6.1.0-M1, the class was removed from the framework. See spring-projects/spring-framework@4d15b58
Because of this, the plugin faces a bug in Jenkins 2.475+.

As StandardReflectionParameterNameDiscoverer class is present in Spring Framework since version 4.0, this shouldn't be a problem to use the plugin with Jenkins prior or more recent than 2.475.

Testing done

I just compiled the plugin

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@alecharp alecharp requested a review from a team as a code owner September 11, 2024 14:23
@basil basil changed the title [JENKINS-73759] Removes deprecated usage of spring framework class [JENKINS-73759] Remove deprecated usage of Spring Framework class Sep 11, 2024
@basil basil added the bug label Sep 11, 2024
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 128aab4 into jenkinsci:master Sep 11, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants