Allow thresholds to be empty

[coffeecup-winner]

The default values for the thresholds are empty strings in the GUI and not zeros. Zeros have a different meaning, they enforce having 0 failed tests, while an empty string means "do not check this threshold".

[jenkinsadmin]

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

[daspilker]

Oh, sorry that we got that wrong. I'm fine with changing the signatures to Integer to allow empty (null) values. But we can't change the defaults because that would break compatibility for people relying on the zeros. Can you change the defaults back?

[coffeecup-winner]

Yes it will break the backward compat, but in this case this is a good thing. Let me try to convince you :) The contribution guide states that "Every option should have the same defaults as the UI", which is not the case here. I personally spent quite some time trying to figure out why the plugin was behaving so strangely in a generated job. I think it might be better to endure the pain now and make people change their code than to continue to confuse the newcomers, of which there will be much more :)

Let me also say that I understand the importance of not breaking the existing code, but I see that the quality of the product and the codebase still takes first priority here (judging by the deprecation policy for example), which is why I ask you to consider breaking the compatibility in this instance.

Still, I am not opposed to leaving the defaults in place (we're building the Job DSL from our own fork anyway), but if you think that we absolutely should not change them, maybe we could do something clever and think of a way to deprecate the current defaults and introduce a way to switch to the new ones, allowing people to use them?

[daspilker]

I will not merge an incompatible change. The docs clearly state that the default value is zero. It's a bit unfortunate in this case that this does not match the plugin's default, but potentially breaking user code is even worse. Restore the default values or I will close the PR.

[coffeecup-winner]

I still believe that changing the defaults would be better for the product, but it is your call :) I've changed them back. Thanks for reviewing the pull request!

[daspilker]

Please open a JIRA issue for changing the defaults. There was a similar issue about changing defaults for the Git plugin (JENKINS-33482). If we find a viable way to warn users about changing defaults (e.g. a warning in the log, failing the seed job, etc), we can change the defaults.

[coffeecup-winner]

Sure, no problem: JENKINS-33554