fix verifying valid script name #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When being passed a full or relative path, only compare the filename for valid characters, not the full path.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
Thanks for the fix. I replaced this PR by #740. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.42, when processing DSLs with the standalone jar, I got warnings:
$ java -jar job-dsl-core-1.42-standalone-jar path/to/my/script.groovy
[...]
Warning: (path/to/my/script.groovy) script names may only contain letters, digits and underscores, but may not start with a digit; support for arbitrary names is deprecated
[...]
This fixes this, by checking only the filename, not the full path.