Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ItemDiscover, ItemCancel, and ScmTag permissions to the Permissions enum #97

Merged
merged 2 commits into from
Jan 24, 2014
Merged

Conversation

justinharringa
Copy link
Contributor

These additional permissions should be useful for other standard permissions.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@daspilker
Copy link
Member

Your pull request contains commits which do not belong to the pull request. Can you rebase your commits to the current master?

These additional permissions should be useful for other standard permissions.
This is more of a readability enhancement which could potentially be useful in the event that other permissions are added to Jenkins in the future.
@justinharringa
Copy link
Contributor Author

I have rebased my commits to the current master. I think this is ready to go now (still learning git). Thanks @daspilker!

@daspilker
Copy link
Member

OK, great. Can you update the Job Reference and the Release Notes on the wiki?

@justinharringa
Copy link
Contributor Author

Yep, I've added the information to both and did a little linking on the Job Reference page.

@daspilker
Copy link
Member

OK, good so far. Can you update the Security section on the Job Reference page? It seems a little bit outdated. And can you replace the incomplete enum code block by an example or two?

@justinharringa
Copy link
Contributor Author

I forgot to mention that I had updated the security section before (did some linking to the enum). But, I've now removed the enum duplication and added a few examples.

daspilker added a commit that referenced this pull request Jan 24, 2014
Added ItemDiscover, ItemCancel, and ScmTag permissions to the Permissions enum
@daspilker daspilker merged commit ac08dad into jenkinsci:master Jan 24, 2014
@justinharringa justinharringa deleted the patch-1 branch December 30, 2015 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants