New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Spotless #637

Merged

timja merged 1 commit into jenkinsci:master from basil:spotless

Aug 15, 2024

Member

basil commented Aug 15, 2024

No description provided.


          Enable Spotless

e09bd49

basil added the skip-changelog label

basil requested a review from a team as a code owner

August 15, 2024 14:05

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/hudson/tasks/junit/JUnitResultArchiver.java

-                      public FormValidation doCheckTestResults(
-                              @AncestorInPath AbstractProject project,
-                              @QueryParameter String value) throws IOException {
+                      public FormValidation doCheckTestResults(@AncestorInPath AbstractProject project, @QueryParameter String value)

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If DescriptorImpl#doCheckTestResults connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

src/main/java/hudson/tasks/test/AbstractTestResultAction.java

                    * @deprecated Replaced by echarts in TODO
                    */
                   @Deprecated
-                  public void doGraph( StaplerRequest req, StaplerResponse rsp) throws IOException {
-                      if(ChartUtil.awtProblemCause!=null) {
+                  public void doGraph(StaplerRequest req, StaplerResponse rsp) throws IOException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning test

Potential CSRF vulnerability: If AbstractTestResultAction#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

src/main/java/hudson/tasks/test/AbstractTestResultAction.java

                    * @deprecated Replaced by echarts in TODO
                    */
                   @Deprecated
-                  public void doGraph( StaplerRequest req, StaplerResponse rsp) throws IOException {
-                      if(ChartUtil.awtProblemCause!=null) {
+                  public void doGraph(StaplerRequest req, StaplerResponse rsp) throws IOException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning test

Potential missing permission check in AbstractTestResultAction#doGraph

src/main/java/hudson/tasks/test/AbstractTestResultAction.java

                   }
                   /**
                    * Generates a clickable map HTML for {@link #doGraph(StaplerRequest, StaplerResponse)}.
                    */
-                  public void doGraphMap( StaplerRequest req, StaplerResponse rsp) throws IOException {
-                      if(req.checkIfModified(run.getTimestamp(),rsp))
+                  public void doGraphMap(StaplerRequest req, StaplerResponse rsp) throws IOException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning test

Potential CSRF vulnerability: If AbstractTestResultAction#doGraphMap connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

src/main/java/hudson/tasks/test/AbstractTestResultAction.java

                   }
                   /**
                    * Generates a clickable map HTML for {@link #doGraph(StaplerRequest, StaplerResponse)}.
                    */
-                  public void doGraphMap( StaplerRequest req, StaplerResponse rsp) throws IOException {
-                      if(req.checkIfModified(run.getTimestamp(),rsp))
+                  public void doGraphMap(StaplerRequest req, StaplerResponse rsp) throws IOException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning test

Potential missing permission check in AbstractTestResultAction#doGraphMap

src/main/java/hudson/tasks/test/TestResultProjectAction.java

@@ @@ -168,12 +172,13 @@ @@
                    * @deprecated Replaced by echarts in TODO
                    */
                   @Deprecated
-                  public void doTrend( final StaplerRequest req, final StaplerResponse rsp ) throws IOException, ServletException {
+                  public void doTrend(final StaplerRequest req, final StaplerResponse rsp) throws IOException, ServletException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning test

Potential missing permission check in TestResultProjectAction#doTrend

src/main/java/hudson/tasks/test/TestResultProjectAction.java

@@ @@ -182,38 +187,40 @@ @@
                    * @deprecated Replaced by echarts in TODO
                    */
                   @Deprecated
-                  public void doTrendMap( final StaplerRequest req, final StaplerResponse rsp ) throws IOException, ServletException {
+                  public void doTrendMap(final StaplerRequest req, final StaplerResponse rsp) throws IOException, ServletException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning test

Potential CSRF vulnerability: If TestResultProjectAction#doTrendMap connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

src/main/java/hudson/tasks/test/TestResultProjectAction.java

@@ @@ -182,38 +187,40 @@ @@
                    * @deprecated Replaced by echarts in TODO
                    */
                   @Deprecated
-                  public void doTrendMap( final StaplerRequest req, final StaplerResponse rsp ) throws IOException, ServletException {
+                  public void doTrendMap(final StaplerRequest req, final StaplerResponse rsp) throws IOException, ServletException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning test

Potential missing permission check in TestResultProjectAction#doTrendMap

src/main/java/hudson/tasks/test/TestResultProjectAction.java

                   }
                   /**
                    * Changes the test result report display mode.
                    */
-                  public void doFlipTrend( final StaplerRequest req, final StaplerResponse rsp ) throws IOException, ServletException {
+                  public void doFlipTrend(final StaplerRequest req, final StaplerResponse rsp) throws IOException, ServletException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning test

Potential CSRF vulnerability: If TestResultProjectAction#doFlipTrend connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

src/main/java/hudson/tasks/test/TestResultProjectAction.java

                   }
                   /**
                    * Changes the test result report display mode.
                    */
-                  public void doFlipTrend( final StaplerRequest req, final StaplerResponse rsp ) throws IOException, ServletException {
+                  public void doFlipTrend(final StaplerRequest req, final StaplerResponse rsp) throws IOException, ServletException {

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing permission check Warning test

Potential missing permission check in TestResultProjectAction#doFlipTrend

timja approved these changes

View reviewed changes

timja merged commit ef972a1 into jenkinsci:master

16 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels