[JENKINS-73943] Remove legacy checkUrl
usage in AggregatedTestResutPublisher/config.jelly
#657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-73943
I've renamed the check method and dropped
checkUrl
attribute completely to let https://github.com/jenkinsci/jenkins/blob/dc4ad7e1a872e6dd9504f6c1ff1f95d84ca6046b/core/src/main/java/hudson/util/FormValidation.java#L625-L727 do its magic and wire things up for us.While
doCheck
sounded generic to me I found no places in code referencing it, so I assume it's safe to rename.Testing done
https://www.loom.com/share/27c91cc2a4d9480c867ed7cca651bd77?sid=ad8da66b-e52e-4e6e-bfc1-3b9525fb384d
https://www.loom.com/share/aaca1ff0b6274d44a102257baacc9fd9?sid=c8d997ed-11d7-4165-825c-ce5d2defcee7
Submitter checklist