Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set Tolerations on pods (master & agents) #239

Closed
pbecotte opened this issue Dec 27, 2019 · 15 comments
Closed

Allow to set Tolerations on pods (master & agents) #239

pbecotte opened this issue Dec 27, 2019 · 15 comments
Labels
enhancement New feature or request stale
Milestone

Comments

@pbecotte
Copy link

Need to set tolerations on the jenkins master/agent pods- doesn't seem to be a way to do so?

@pawelprazak pawelprazak added the enhancement New feature or request label Dec 30, 2019
@pawelprazak
Copy link

pawelprazak commented Dec 30, 2019

Yes, thank you, this is another thing we need to address with #196

Also the master pod needs to have this configurable.

As for the dynamically created pods it should be possible from the pipeline.

@pawelprazak pawelprazak changed the title Tolerations? Allow to set Tolerations on pods (master & agents) Dec 30, 2019
@pbecotte
Copy link
Author

Good point, the agent config is in the configuration as code plugin, just hadn't gotten there yet since the master can't deploy :)

@pbecotte
Copy link
Author

As a question- I still can't figure out any way to work around this. Before I decide to uninstall this operator and get this working with the helm chart, is there a workaround that I'm not seeing?

@tomaszsek
Copy link

Tolerations for Jenkins master pod can be set in https://github.com/jenkinsci/kubernetes-operator/releases/tag/v0.3.1. We have to wait for #196 to set tolerations for seed job agent and I there is no workaround for this 😢

@pbecotte
Copy link
Author

That is an impressive turnaround time!

@tomaszsek
Copy link

In https://github.com/jenkinsci/kubernetes-operator/releases/tag/v0.3.3 the tolerations for seed job agent are copied from spec.master.tolerations.

@deeco
Copy link

deeco commented Feb 19, 2020

How can this be set ? I have tried adding under master in values.yaml
master: \ tolerations: [node.kubernetes.io/disk-pressure:NoSchedule]

@pbecotte
Copy link
Author

That's not the format for tolerations:

                    tolerations:
                      - effect: NoSchedule
                        key: program
                        operator: Equal
                        value: $(PROGRAM)

@deeco
Copy link

deeco commented Feb 19, 2020

That's not the format for tolerations:

                    tolerations:
                      - effect: NoSchedule
                        key: program
                        operator: Equal
                        value: $(PROGRAM)

So what would the equivalent be for the above disk-pressure ?

@deeco
Copy link

deeco commented Feb 19, 2020

believe found it here, https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/

`tolerations:

  • key: "node.kubernetes.io/unreachable"
    operator: "Exists"
    effect: "NoExecute"
    tolerationSeconds: 6000`

@deeco
Copy link

deeco commented Feb 19, 2020

works , thanks @pbecotte

@admssa
Copy link

admssa commented Mar 26, 2020

Does an agent have the same toleration parameter as a master, or tolerations work for master only?

@pbecotte
Copy link
Author

agent configuration goes in the configuration-as-code configmap.

clouds:
  - kubernetes:
      name: kubernetes
      templates:
        - name: default
           tolerations: ...

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this issue is still affecting you, just comment with any updates and we'll keep it open. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@Sig00rd Sig00rd added this to the New API milestone Jul 28, 2021
@stale stale bot removed the stale label Jul 28, 2021
@github-actions github-actions bot added the stale label May 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2023
@brokenpip3
Copy link
Collaborator

duplicate of #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

7 participants