Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nodeSelectors for the seed job agent. #257

Closed
salluvada opened this issue Jan 28, 2020 · 3 comments
Closed

Implement nodeSelectors for the seed job agent. #257

salluvada opened this issue Jan 28, 2020 · 3 comments

Comments

@salluvada
Copy link

salluvada commented Jan 28, 2020

Currently in the Jenkins custom resource manifest, even if I provide a nodeSelector, the generated seed job deployment is not having that. Due to this issue, the seed job agent is stuck in a ContainerCreating state when I am trying this on an EKS cluster with multiple node groups (linux and windows). The VPC admission webhook needs the nodeSelector item to be present in the podmanifest without which, it is not adding the label "vpc.amazonaws.com/PrivateIPv4Address" to the pod.

Error in
failed to parse Kubernetes args: pod does not have label vpc.amazonaws.com/PrivateIPv4Address

Below is the seed jobs section of the jenkins custom resource manifest. The generated deployment is not having the nodeSelector in it.

  seedJobs:
  - id: jenkins-operator
    targets: "cicd/jobs/*.jenkins"
    description: "Jenkins Operator repository"
    repositoryBranch: master
    repositoryUrl: https://github.com/jenkinsci/kubernetes-operator.git
    nodeSelector:
      beta.kubernetes.io/os: linux
@tomaszsek
Copy link

Hi @salluvada,

If the operator will populate the node selector from spec.master.nodeSelector it will work for you?

Cheers

@salluvada
Copy link
Author

Hi @tomaszsek That would definitely work for me. Thanks.

tomaszsek added a commit that referenced this issue Jan 30, 2020
tomaszsek added a commit that referenced this issue Jan 30, 2020
@tomaszsek
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants