Unable to specify custom plugin location in the jenkins cr

[salluvada]

Currently, we are only able to specify plugin name and version for downloading plugins. I have come across a situation where I have a couple of plugins that need to be downloaded from a custom url location and not the jenkins UC.

It would be nice if we can specify some thing like

plugins:
# downloads from the default UC
- name: git
  version: 4.0.0    
# downloads from the user provided url. 
- name: devoptics
  version: 1.2.1
  downloadurl: https://downloadurl/devoptics.hpi   

[salluvada]

I think it is possible. currently the operator must be concatenating the plugin name and the version number while passing as parameter to install-plugins.sh. If it also concatenates the userprovided url, it would work IMO.

 echo "Downloading plugins..."
    for plugin in "${plugins[@]}"; do
        local reg='^([^:]+):?([^:]+)?:?([^:]+)?:?(http.+)?'
        if [[ $plugin =~ $reg ]]; then
            local pluginId="${BASH_REMATCH[1]}"
            local version="${BASH_REMATCH[2]}"
            local lock="${BASH_REMATCH[3]}"
            local url="${BASH_REMATCH[4]}"
            download "$pluginId" "$version" "${lock:-true}" "${url}" &
        else
          echo "Skipping the line '${plugin}' as it does not look like a reference to a plugin"
        fi
    done

The below snippet is downloading the first plugin from jenkins UC and the second plugin from custom plugin location

/usr/local/bin/install-plugins.sh "cloudbees-devoptics-enabler" "devoptics:latest:https://jenkins-updates.cloudbees.com/download/plugins/devoptics/latest/devoptics.hpi"

[tomaszsek]

Hi @salluvada,

If would like to contribute here you have required code changes:

• add new field DownloadURL to Jenkins CR https://github.com/jenkinsci/kubernetes-operator/blob/master/pkg/apis/jenkins/v1alpha2/jenkins_types.go#L247
• add new field DownloadURL to internal plugin struct https://github.com/jenkinsci/kubernetes-operator/blob/master/pkg/controller/jenkins/plugins/plugin.go#L12
• add validation of new filed https://github.com/jenkinsci/kubernetes-operator/blob/master/pkg/controller/jenkins/plugins/plugin.go#L49
• include DownloadURL when rendering plugins list passed to the install-plugins.sh command
  https://github.com/jenkinsci/kubernetes-operator/blob/master/pkg/controller/jenkins/configuration/base/resources/scripts_configmap.go#L271
  https://github.com/jenkinsci/kubernetes-operator/blob/master/pkg/controller/jenkins/configuration/base/resources/scripts_configmap.go#L285

Cheers

[salluvada]

hey thanks @tomaszsek

[tomaszsek]

Added in https://github.com/jenkinsci/kubernetes-operator/releases/tag/v0.4.0