Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow seed job scm to be configured with github-branch-source/GitHubAppCredentials #614

Closed
andlaz opened this issue Aug 5, 2021 · 2 comments · Fixed by #719
Closed

Allow seed job scm to be configured with github-branch-source/GitHubAppCredentials #614

andlaz opened this issue Aug 5, 2021 · 2 comments · Fixed by #719
Assignees
Labels
enhancement New feature or request stale

Comments

@andlaz
Copy link

andlaz commented Aug 5, 2021

Describe the solution you'd like
I'd like for the operator to allow GitHubAppCredentials type credentials to configure the git SCM for seed jobs. This is already supported in the git SCM, i suppose because GitHubAppCredentials implements StandardUsernamePasswordCredentials ..but i'm not sure. I know i can update the credentials on the operator-created seed job ( with no other changes ) and scan and checkout will both work.

Describe alternatives you've considered
Moving away from personal access tokens to github apps, there isn't an alternative it seems: I currently configure the seed job with an app client secret ( username + password ) that validates in the operator but fails to authenticate at scan-time. I log in to the UI, update the seed job credential to the GitHubAppCredentials one ( appid + private key ) and everything works.

@andlaz andlaz added the enhancement New feature or request label Aug 5, 2021
@stale
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this issue is still affecting you, just comment with any updates and we'll keep it open. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 16, 2022

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
2 participants