Seed job SCM may now be configured with github-branch-source/GitHubAppCredentials

[andlaz]

Changes

resolves #614

Submitter Checklist

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

Reviewer Notes

Release Notes

[andlaz]

i could use some hints as to, where i need to make a change in e2e tests to make this pass please? It's indirectly an API change because of the extension of CR validation to allow the use of GitHubAppCredentials in the seedJobs array

thanks @Sig00rd for re-running, looks like the issue could have been in the env

[Sig00rd]

Hi @andlaz and thanks for contributing this, could you also add some test cases for validating this credential type in https://github.com/jenkinsci/kubernetes-operator/blob/master/pkg/configuration/user/seedjobs/validate_test.go ?

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this pull request is still relevant, just comment with any updates and we'll keep it open. Thank you for your contributions.

[andlaz]

Could this please be merged?

[mario21ic]

this is the PR that I just need.
could somebody merge this PR? 🙏

[Sig00rd]

Sorry for the delay!