Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: configure additional environment variables for master pod from secrets #9

Closed
adaniline-traderev opened this issue Feb 25, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@adaniline-traderev
Copy link

I'd like to pass a secret value to script / SACS config - for example, OATH2 client secret, etc - see example at https://github.com/jenkinsci/configuration-as-code-plugin/blob/5479188627778acca60b56e318bd899bf18ae131/demos/kubernetes-secrets/README.md

Would be nice if in Jenkins.master I could configure additional environment variables ([]core.v1. EnvVar) for the master container

@tomaszsek tomaszsek added the enhancement New feature or request label Feb 26, 2019
@tomaszsek
Copy link

I think we should introduce secret which will be automatically mounted in Jenkins for configuration purpose as a default. Then configuration as a code plugin or groovy scripts can use it.

Of course we can give possibility to configure pod envs as well, but every change will cause Jenkins master pod to restart which we try to avoid.

@adaniline-traderev
Copy link
Author

Still, I think it would be nice to be able to set env variables or mount user's config maps or secrets as volumes for the master pod - along the lines of podTemplate

@tomaszsek
Copy link

tomaszsek added a commit that referenced this issue Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants