Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to operator-sdk v.0.17.0 #363

Merged
merged 1 commit into from
May 4, 2020

Conversation

akram
Copy link

@akram akram commented May 4, 2020

Changes

Move to operator-sdk v.0.17.0

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

N/A

Release Notes

Move to operator-sdk v.0.17.0

@akram
Copy link
Author

akram commented May 4, 2020

This is required for this: #357

@akram
Copy link
Author

akram commented May 4, 2020

pkg/test: only register --kubeconfig if not registered, get value if already registered
Motivation for the change: controller-runtime currently adds the --kubeconfig flag if pkg/client/config is imported (set up in an init() function). The SDK's test framework also adds this flag, which will panic if both packages are imported and the test framework is initialized.

@tomaszsek tomaszsek merged commit b66fab6 into jenkinsci:master May 4, 2020
@tomaszsek tomaszsek added the enhancement New feature or request label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants