Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labels and annotations to example of ssh private key configuration #435

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

smolin
Copy link

@smolin smolin commented Jul 8, 2020

Changes

ssh private key authentication seems to require labels, and annotations are very helpful

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [ n/a ] Includes tests (if functionality changed/added)
  • [ y ] Includes docs (if user facing)
  • [ kinda ] Commit messages follow commit message best practices

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS.

Release Notes

No user-facing changes

ssh private key authentication seems to require labels, and annotations are very helpful
@smolin smolin changed the title add labels and annotations add labels and annotations to example of ssh private key configuration Jul 8, 2020
@tomaszsek tomaszsek merged commit 96522e3 into jenkinsci:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants