-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build multi-arch images #693
Conversation
I am still investigating why there is a timeout when running e2e tests. |
Makefile
Outdated
--output=type=docker --platform linux/$* \ | ||
--build-arg GO_VERSION=$(GO_VERSION) \ | ||
--build-arg CTIMEVAR="$(CTIMEVAR)" \ | ||
--tag $(DOCKER_REGISTRY):$(GITCOMMIT) . \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add the plateform to the tag name, something like
--tag
4fdf07d
to
687ee40
Compare
0a8f405
to
410b66b
Compare
410b66b
to
7078f8c
Compare
7078f8c
to
9e3aa09
Compare
/assign @Sig00rd |
Thanks @glebiller, great work! |
Changes
Changed Dockerfile & Makefile to build a multi-platform (amd64 and arm64) image of jenkins-operator.
Using
TARGETOS
andTARGETARCH
in the builder and leveragedocker build build
command in the Makefile.💥 Breaking changes 💥
It is required to run
docker buildx create --use
before being able to create & push the image to registry.Currently podman does not support buildx features, this changes requires
CONTAINER_RUNTIME_COMMAND=docker
.🧪 Unit tests changes 🧪
Fixing unit tests with the following changes:
1
to250m
jenkins/jenkins:2.319.3-lts
Release Notes