Pod Template "Annotations" Field #105
Conversation
There was a problem hiding this comment.
Thanks! You also need to update https://github.com/jenkinsci/kubernetes-plugin/blob/master/src/main/resources/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep/config.jelly
And it helps reviewing changes if formatting (space changes) is done separately
|
Whoops, sorry about those whitespace changes. I'll clean those up, and add the jelly soon. Thanks! |
|
@carlossg Hey sorry this took so long. I completely forgot that I had made this PR until about a week ago. Anyway, I removed those whitespace changes so this PR should be easier to review now. I've also added an annotation element to the jelly. LMK if there's anything else. |
|
thanks! just 2 things left a help blurb for the UI in https://github.com/austinmoore-/kubernetes-plugin/tree/83638c902614be0ff7cdcb8384589cfe63593af1/src/main/resources/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep an update to the examples to show how to use it in https://github.com/jenkinsci/kubernetes-plugin#container-configuration |
|
This is awesome, we're looking for this exact feature set in order to use annotations to specify pod anti-affinity to better spread our jenkins builds over nodes with attached SSD's. |
| @@ -56,6 +56,7 @@ public boolean start() throws Exception { | |||
| newTemplate.setContainers(step.getContainers()); | |||
| newTemplate.setNodeSelector(step.getNodeSelector()); | |||
| newTemplate.setServiceAccount(step.getServiceAccount()); | |||
| newTemplate.setAnnotations(step.getAnnotations()); | |||
There was a problem hiding this comment.
FYI when upgrading getAnnotations() is going to be null, because is loaded from xml config where it doesn't exist, have you checked that the API won't break with a null value?
There was a problem hiding this comment.
I was unaware of that. I just did a test where I upgraded from 0.7, to my version, and all the data remained.
I believe it worked because I declare annotations here with an initial value: https://github.com/jenkinsci/kubernetes-plugin/pull/105/files#diff-37ffb9809d7b186d5733b266c664ba41R36
There was a problem hiding this comment.
the initial value won't be used when loading the xml config from disk, so maybe it's better if you explicitly add a readResolve that sets annotations to empty list if it is null
austinmoore-
force-pushed
the
pod-template-annotations
branch
from
1014105
to
f0cb74d
Compare
austinmoore-
force-pushed
the
pod-template-annotations
branch
from
f0cb74d
to
cbe6fca
Compare
|
In the most recent commits I've added a null check to |
|
thanks! |
|
when we can expect a release with this feature? |
|
ignore me, I see it was just released in 0.11 keep up the good work, thanks! |
Adds the ability to specify a list of annotations to create the pod with.