[JENKINS-49707] Allow node blocks from deleted pods to be retried
#1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
approved these changes
Jun 6, 2022
fcojfernandez
approved these changes
Jun 7, 2022
Merge branch 'master' of https://github.com/jenkinsci/kubernetes-plugin into retry-JENKINS-49707-base
… into retry-JENKINS-49707-base
jglick
commented
Jul 7, 2022
Comment on lines
93
to
96
| if (!(n instanceof KubernetesSlave)) { | ||
| LOGGER.fine(() -> node + " was not a K8s agent"); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
jglick
commented
Jul 7, 2022
Vlatombe
approved these changes
Jul 8, 2022
|
Still a couple tweaks I want to make here. |
jglick
commented
Jul 9, 2022
...ain/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesAgentErrorCondition.java
Outdated
Show resolved
Hide resolved
dduportal
approved these changes
Jul 9, 2022
|
@Vlatombe ready for release from my perspective. ci.jenkins.io is already running an earlier version of this. |
Vlatombe
approved these changes
Jul 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/workflow-api-plugin#217, jenkinsci/workflow-durable-task-step-plugin#231, & jenkinsci/workflow-basic-steps-plugin#203. Main functionality (without support for Declarative syntax) extracted from #1083, and without cross-restart tests.