Cleanup environment variable mapping, allow overriding HOME env variable #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iocanel
reviewed
Feb 13, 2017
| // Running on OpenShift Enterprise, security concerns force use of arbitrary user ID | ||
| // As a result, container is running without a home set for user, resulting into using `/` for some tools, | ||
| // and `?` for java build tools. So we force HOME to a safe location. | ||
| env.put("HOME", containerTemplate.getWorkingDir()); |
iocanel
reviewed
Feb 13, 2017
| env.add(new EnvVar("HOME", containerTemplate.getWorkingDir(), null)); | ||
|
|
||
| // Convert our env map to an array | ||
| EnvVar[] envVars = env.entrySet().stream() |
|
@drcapulet: Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the mounting a drive at
/home/jenkinswipes out the directory (which has dot files we'd like to keep around), I wanted to mount the workspace in a subdirectory. Unfortunately, by overridingHOMEwe can't use the dotfiles. This sets a defaultHOMEto be the workspace directory but allows an override from either the pod or container config. Also removes duplicate env vars from being sent to be more explicit.Wasn't sure how best to test this since
createContainer(and its callers) are all private, and no other examples exist inKubernetesCloudTest.