[JENKINS-41287] Fix error when job contains spaces #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` [job with spaces] Running shell script Executing shell script inside container [busybox] of pod [kubernetes-8557fdf9781e4cf2a61886465194237f-38066e920443] Executing command: sh -c echo $$ > '/home/jenkins/workspace/job with spaces@tmp/durable-aa4b60a9/pid'; jsc=durable-e34518f433054f84ad6d3027eca192a2; JENKINS_SERVER_COOKIE=$jsc '/home/jenkins/workspace/job with spaces@tmp/durable-aa4b60a9/script.sh' > '/home/jenkins/workspace/job with spaces@tmp/durable-aa4b60a9/jenkins-log.txt' 2>&1; echo $? > '/home/jenkins/workspace/job with spaces@tmp/durable-aa4b60a9/jenkins-result.txt' /home/jenkins # cd "/home/jenkins/workspace/job with spaces" /home/jenkins/workspace/job with spaces # sh -c echo $$ > '/home/jenkins/workspa ce/job with spaces@tmp/durable-aa4b60a9/pid'; jsc=durable-e34518f433054f84ad6d30 27eca192a2; JENKINS_SERVER_COOKIE=$jsc '/home/jenkins/workspace/job with spaces@ tmp/durable-aa4b60a9/script.sh' > '/home/jenkins/workspace/job with spaces@tmp/d urable-aa4b60a9/jenkins-log.txt' 2>&1; echo $? > '/home/jenkins/workspace/job wi th spaces@tmp/durable-aa4b60a9/jenkins-result.txt' /home/jenkins/workspace/job with spaces # exit + pwd /home/jenkins/workspace/job with spaces ```
iocanel
reviewed
Feb 13, 2017
| @@ -122,7 +122,7 @@ public void onClose(int i, String s) { | |||
|
|
|||
| //We need to get into the project workspace. | |||
| //The workspace is not known in advance, so we have to execute a cd command. | |||
| watch.getInput().write(("cd " + path + NEWLINE).getBytes(StandardCharsets.UTF_8)); | |||
| watch.getInput().write(String.format("cd \"%s\"%s", path, NEWLINE).getBytes(StandardCharsets.UTF_8)); | |||
There was a problem hiding this comment.
is this a change just for efficiency or there is more into it?
There was a problem hiding this comment.
the path quotes were missing
jglick
added a commit
to jglick/kubernetes-plugin
that referenced
this pull request
Jun 10, 2019
…x a flake in PodTemplateStepExecutionTest.testBadLabel.
Vlatombe
added a commit
that referenced
this pull request
Jun 27, 2019
[JENKINS-46076] Hoping that workflow-job-plugin #131 will fix a flake in PodTemplateStepExecutionTest.testBadLabel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-41287