Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: support idleMinutes field in pipeline #154

Merged
merged 3 commits into from
Jun 1, 2017
Merged

Feat: support idleMinutes field in pipeline #154

merged 3 commits into from
Jun 1, 2017

Conversation

zoumo
Copy link
Contributor

@zoumo zoumo commented Apr 11, 2017

No description provided.

@zoumo
Copy link
Contributor Author

zoumo commented Apr 11, 2017

Can someone tell me what's wrong with my PR?

@carlossg
Copy link
Contributor

carlossg commented Apr 11, 2017 •
edited
Loading

it's in the linked jenkins report at https://jenkins.ci.cloudbees.com/job/plugins/job/kubernetes-plugin/542/console

[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Self assignment of field PodTemplateStep.idleMinutes in org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStep.setIdleMinutes(int) [org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStep] At PodTemplateStep.java:[line 133] SA_FIELD_SELF_ASSIGNMENT

iocanel
iocanel requested changes Apr 11, 2017
View reviewed changes
src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep.java Outdated

@DataBoundSetter
public void setIdleMinutes(int instanceCap) {
this.idleMinutes = idleMinutes;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoumo: This is why the build fails. I guess you need to change the method argument to idleMinutes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

carlossg
carlossg reviewed Apr 16, 2017
View reviewed changes
Copy link
Contributor

@carlossg carlossg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It just needs a help entry for the pipeline editor under https://github.com/fabric8io/kubernetes-plugin/tree/master/src/main/resources/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep

@zoumo
Copy link
Contributor Author

zoumo commented Apr 24, 2017

got it

carlossg
carlossg requested changes May 4, 2017
View reviewed changes
Copy link
Contributor

@carlossg carlossg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for the docs

@zoumo
Copy link
Contributor Author

zoumo commented May 12, 2017

@carlossg @iocanel help doc is ok now

@carlossg carlossg merged commit d98c332 into jenkinsci:master Jun 1, 2017
@carlossg
Copy link
Contributor

carlossg commented Jun 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

@carlossg carlossg carlossg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoumo @carlossg @iocanel