Step namespace should have priority over anything else. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossg
reviewed
May 17, 2017
| @@ -204,6 +204,28 @@ public void runWithOverriddenNamespace() throws Exception { | |||
| r.assertLogContains(overriddenNamespace, b); | |||
| } | |||
|
|
|||
| @Test | |||
| public void runWithOverriddenNamespace2() throws Exception { | |||
There was a problem hiding this comment.
should this just be the only runWithOverriddenNamespace test ?
I'm not sure what the other one was testing because the namespace was not in the pipeline
There was a problem hiding this comment.
runWithOverriddenNamespace is meant to verify that if a namespace is not explicitly specified it will be picked up from the NamespaceAction.
runWithOverriddenNamespace2 is meant to verify that if a namepsace IS explictly specified its the one that will be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.