Add support for initContainers

[ClementGautier]

Hello there,

As mentioned in #229 , the support for initContainers as podAnnotation is no longer an option for k8s >=1.8 so I gave a follow up to this pull request by using the latest version of kubernetes-client so we can use withInitContainers on the pod builder.

I'm definitely not a Java developer so I hope I'm not doing too many mistakes in this pull request.

[ClementGautier]

@carlossg : I've rebased, run the tests suite locally and the CI seems good too. What's the next step ?

[ClementGautier]

Oh, nevermind, the 2nd ci broke. ( by the way it's very confusing to have both ci.jenkins.io and jenkins.gke.csanchez.org sharing the same github status name )

Any clue on the failures ? when I run that locally using docker it works fine

[carlossg]

You can see them at https://jenkins.gke.csanchez.org/blue/organizations/jenkins/jenkinsci%2Fkubernetes-plugin/detail/PR-254/5/tests

[ClementGautier]

Sorry if I insist but how can I reproduce this ? Locally if I run

docker run -v $(pwd):/app -w /app -it maven:3.5.0-jdk-8-alpine bash
bash-4.3# mvn -B clean install -Dmaven.test.skip=true -Dfindbugs.fork=false
bash-4.3# mvn -B test -DconnectorHost=0.0.0.0

Everything runs fine... is it related to the maven cache layer (means I don't pull the same dependencies than your jenkins instance ?). (Sorry again if I ask stupid questions, it's like my first java related pull request ever).

[carlossg]

you need minikube running and check that there are no tests "skipped"

[ClementGautier]

Ok, thanks for the hint, I will try to setup that

[ClementGautier]

As this will become useless when #275 will be done and given the fact that I will not have time to complete this PR (we don't need it at work as we don't make use of init-containers for our builds) I'll close it.

[ilakhtenkov]

Could this be reopened? Because in case of definition of init containers and inheritence one template from another Init containers from child template are getting lost.

[dg424]

Can we reopen this feature request ? Where on this page - https://kubernetes.io/docs/concepts/workloads/pods/init-containers/ - does it say Init Containers are deprecated as 1.18 ?

[ClementGautier]

@dg424 not 1.18 but 1.8 (yup that's old stuff) and it was not init containers per say but the ability to declare init containers through annotations (once upon a time, before init container became stable in 1.6, you needed to defined them inline in the pod.beta.kubernetes.io/init-containers annotation, here is an example). This pull request basically was here to bring the native support for the new way of defining init-containers.

I don't have the time to work on that but be welcomed to pick up the code were I left it (or better, start from scratch because this is 4 years old so the code might have changed a lot since). As a workaround I suggest using the yaml syntax that, of course, supports everything (it must be such a pain to maintain the compatibility between the dsl and native syntax that I'm surprised it hasn't been dropped yet).