Bump kubernetes-client to 3.1.10 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The command execution in v3 is a lot slower than in v2, all the times I've tried there is a consistent gap of 30 seconds where nothing happens |
There is a wait of 30 seconds somewhere
|
Up to 5 threads in the testCommandExecution is fine, over that there is the 30 seconds wait. Some threads may finish in a second, rest will finish after the 30 secs |
|
@carlossg: OOTB the client supprts up to 5 concurrent requests per host (see 1). This is actually passed to okhttp and I am not quite sure how it handles it internally, but it does look very suspicious. Can you try increasin that number and see if that makes any difference? Also, I think that its essential to merge this: #239 as it will dramatically reduce the number of requests. |
|
Actually this test broke between kubernetes-client 2.6.2 and 2.6.3 #239 did not solve it |
carlossg
added a commit
to carlossg/kubernetes-client
that referenced
this pull request
Jan 30, 2018
Minimal test from jenkinsci/kubernetes-plugin#271
carlossg
added a commit
to carlossg/kubernetes-client
that referenced
this pull request
Jan 30, 2018
Minimal test from jenkinsci/kubernetes-plugin#271
|
The changes in PR fabric8io/kubernetes-client#855 broke the test, from v2.6.3 to v3.1.6 (included). Threads would hang forever on waitUntilReady In 3.1.7+ the problem is different, it will eventually succeed, but with 30 second pauses I've filed fabric8io/kubernetes-client#997 |
|
Waiting for a release > 3.1.8 with fabric8io/kubernetes-client@83eda0c |
carlossg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.