Allow specifying a different shell command other than /bin/sh

[lbouquety]

We need to be able, in our containers, to load profile files (.bash_rc, .profile, ...) at runtime. /bin/sh, while it's often just a link to /bin/bash puts you in a compatibility mode that doesn't load these files.

We run this Jenkins plugin against an OpenShift cluster that, by default, runs containers with an undefined UID. Being able to load variables from "profile" files is critical for us.

The implementation is retro compatible with the already written jenkinsfiles, but let's you override the interpreter you will use to run commands in your container (in our case, we mostly want to use bash).

An example of Jenkinsfile with the modification:

podTemplate(name: 'maven', label: 'maven', containers: [
  containerTemplate(name: 'maven', image: 'maven:latest', ttyEnabled: true, command: 'cat', alwaysPullImage: true),
  containerTemplate(name: 'jnlp', image: 'openshift/jenkins-slave-base-centos7', args: '${computer.jnlpmac} ${computer.name}', alwaysPullImage: true),
  ]) {

  node('maven') {
    stage('Build a Maven project') {
      container(name:'maven', shell:'/bin/bash') {
        sh 'mvn -version'
      }
    }
  }
}

[carlossg]

doesn't this achieve the same result?

  container('maven') {
    sh """#!/bin/bash
      mvn -version
    """
  }

[lbouquety]

It does achieve the same result, but the resulting Jenkinsfile with my patch looks more developer friendly, IMHO.

[carlossg]

I think I'm ok adding this. It's just missing some docs and using the shell param in one of the non-declarative tests to ensure it works

[nodefourtytwo]

The test failure seems unrelated to this PR, could it be replayed or investigated?

[carlossg]

merged , thanks