[JENKINS-50913] Do not pass arguments to jnlp container #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They haven't been needed for a while and can't be merged easily from parent to children
Vlatombe
approved these changes
Apr 24, 2018
scoheb
added a commit
to scoheb/jenkins-1
that referenced
this pull request
May 24, 2018
As of version 1.6.0 of the Jenkins Kubernetes plugin, args are no longer passed to jnlp container if not present in containerTemplate See jenkinsci/kubernetes-plugin#315 This is made worse if using Declarative pipeline and specifying yaml for the podTemplate. since ${computer.*} is not resolvable. To workaround this, we use JENKINS_SECRET and JENKINS_NAME for launcher arguments See https://gist.github.com/scoheb/f29d263c240e8880648b920240635ed6 for an example Jenkinsfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They haven't been needed for a while and can't be merged easily from parent to children
Fixes regression introduced in #305